https://bugzilla.redhat.com/show_bug.cgi?id=2193288
--- Comment #3 from Felix Wang <topazus(a)outlook.com> ---
Thanks for your reviewing the package.
a) Main license seems to be BSD-3-Clause with a few files under MIT license.
Is it possible
to add a license breakdown in the spec file?
The main license is under BSD-3-Clause license, the external libraries of
cxxopts and nlohmann-json are under MIT license. For the testing data, I
disable the tests. Do I also need to add the license of the testing data?
ref:
https://github.com/f3d-app/f3d/blob/master/doc/THIRD_PARTY_LICENSES.md
https://github.com/f3d-app/f3d/blob/master/testing/data/DATA_LICENSES.md
b) Can the Java bindings also be built?
I added build option of the java binding.
c) Can files in external directory be obtained from those packaged in Fedora?
https://github.com/f3d-app/f3d/blob/master/external/json.hpp
https://github.com/f3d-app/f3d/blob/master/external/cxxopts.hpp
opened the issue from the upstream repository.
https://github.com/f3d-app/f3d/issues/801
d) Building the example may be useful as a basic functionality test
I do not see the example building of the source code.
e) Please use desktop-file-validate see
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_...
added this desktop file validation.
f) libraries in main package should have sonames, in particular libf3d, plugin
libraries used only
internally need not have sonames, but should then be in a subdirectory not in
the LD_LIBRARY_PATH
g) devel package should have libraries without sonames, see
https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/#_lib...
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_soname_handling
issue:
https://github.com/f3d-app/f3d/issues/801
h) Where possible list file extensions used rather than just including an
entire directory, for example
%files devel
%{_includedir}/f3d/*.h
%{_libdir}/cmake/f3d/*.cmake
%{_libdir}/cmake/f3d/*.in
have done this.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2193288