Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: beldi - Belug Linux Distribution Burner
https://bugzilla.redhat.com/show_bug.cgi?id=249949
------- Additional Comments From redhat-bugzilla(a)linuxnetz.de 2008-07-13 17:17 EST
-------
(In reply to comment #16)
FAIL - MUST: The License field in the package spec file does not
match the
actual license: Code is GPLv3+, but License tag is GPLv2+
FAIL - MUST: License text from source is included in %doc, but the License is
out of date (GPLv2)
Changed to GPLv3+ in the spec file, sent e-mail to upstream to correct that for
the next upstream release.
FAIL - MUST: All build dependencies are listed in BuildRequires, but
gtkglextmm-devel is only needed when building with --enable-opengl. The OpenGL
interface looks really cool and works here and so I suggest to include it.
What do you think?
I agree with you, enabled now. Thought, that would be catched up automagically
once the dependency is satified, but it looks not as it would be the case.
FIX - SHOULD: Please bug upstream to include an updated copy of the
license
text.
Done, see above and within your mailbox.
FIX? - SHOULD: Could you include a German translation of description
and
summary?
No not really, this is something for specspo package.
FIX - SHOULD: Typo in description: less -> least, consist ->
consists.
IMHO the description could be simplified a little:
I've taken your rewrite now, sounds better. Former description was taken from
the Beldi website.
NEEDSWORK
Done, SRPM:
http://labs.linuxnetz.de/bugzilla/beldi-0.9.16-3.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.