https://bugzilla.redhat.com/show_bug.cgi?id=2168112
--- Comment #65 from Benson Muite <benson_muite(a)emailplus.org> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-Clause License", "*No
copyright*
BSD 3-Clause License". 2089 files have unknown license. Detailed
output of licensecheck in
/home/FedoraPackaging/reviews/phpunit-10/2168112-phpunit10/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: phpunit10-10.2.6-1.fc38.noarch.rpm
phpunit10-10.2.6-1.fc38.src.rpm
=============================================== rpmlint session starts
===============================================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpuibmkyss')]
checks: 31, packages: 2
phpunit10.noarch: W: no-manual-page-for-binary phpunit10
phpunit10.spec: W: invalid-url Source0: phpunit10-10.2.6-1c17815.tgz
phpunit10.noarch: E: env-script-interpreter /usr/bin/phpunit10 /usr/bin/env php
================ 2 packages and 0 specfiles checked; 1 errors, 2 warnings, 1
badness; has taken 3.5 s ================
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1
phpunit10.noarch: W: no-manual-page-for-binary phpunit10
phpunit10.noarch: E: env-script-interpreter /usr/bin/phpunit10 /usr/bin/env php
1 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken
1.1 s
Requires
--------
phpunit10 (rpmlib, GLIBC filtered):
(php-composer(myclabs/deep-copy) >= 1.10.1 with
php-composer(myclabs/deep-copy) < 2)
(php-composer(phar-io/manifest) >= 2.0.3 with
php-composer(phar-io/manifest) < 3)
(php-composer(phar-io/version) >= 3.0.2 with php-composer(phar-io/version)
< 4)
(php-composer(phpunit/php-code-coverage) >= 10.1.1 with
php-composer(phpunit/php-code-coverage) < 11)
(php-composer(phpunit/php-file-iterator) >= 4.0 with
php-composer(phpunit/php-file-iterator) < 5)
(php-composer(phpunit/php-invoker) >= 4.0 with
php-composer(phpunit/php-invoker) < 5)
(php-composer(phpunit/php-text-template) >= 3.0 with
php-composer(phpunit/php-text-template) < 4)
(php-composer(phpunit/php-timer) >= 6.0 with
php-composer(phpunit/php-timer) < 7)
(php-composer(sebastian/cli-parser) >= 2.0 with
php-composer(sebastian/cli-parser) < 3)
(php-composer(sebastian/code-unit) >= 2.0 with
php-composer(sebastian/code-unit) < 3)
(php-composer(sebastian/comparator) >= 5.0 with
php-composer(sebastian/comparator) < 6)
(php-composer(sebastian/diff) >= 5.0 with php-composer(sebastian/diff) < 6)
(php-composer(sebastian/environment) >= 6.0 with
php-composer(sebastian/environment) < 7)
(php-composer(sebastian/exporter) >= 5.0 with
php-composer(sebastian/exporter) < 6)
(php-composer(sebastian/global-state) >= 6.0 with
php-composer(sebastian/global-state) < 7)
(php-composer(sebastian/object-enumerator) >= 5.0 with
php-composer(sebastian/object-enumerator) < 6)
(php-composer(sebastian/recursion-context) >= 5.0 with
php-composer(sebastian/recursion-context) < 6)
(php-composer(sebastian/type) >= 4.0 with php-composer(sebastian/type) < 5)
(php-composer(sebastian/version) >= 4.0 with
php-composer(sebastian/version) < 5)
/usr/bin/env
php(language)
php-cli
php-composer(fedora/autoloader)
php-dom
php-json
php-libxml
php-mbstring
php-openssl
php-pcntl
php-pcre
php-phar
php-reflection
php-spl
php-xml
php-xmlwriter
Provides
--------
phpunit10:
phpunit10
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2168112 -m fedora-38-x86_64
Buildroot used: fedora-38-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: R, Python, PHP, Ruby, Java, C/C++, Perl, Haskell, fonts,
SugarActivity, Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comments:
a) 10.2.7 has just been released
b) One error phpunit10.noarch: E: env-script-interpreter /usr/bin/phpunit10
/usr/bin/env php
c) Requires seem correct, though phpcompatinfo seems to need a lot of memory,
so have not checked it, but other requirements seem ok.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2168112
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...