Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705104
--- Comment #6 from Ankur Sinha <sanjay.ankur(a)gmail.com> 2011-05-29 03:33:04 EDT
---
Hi Volker!
Thank you for the comments!
(In reply to comment #5)
I can't rebuild your source package. Something is wrong with your
qmake
options, it seems.
Uhm, I just rebuilt it in mock and it built correctly.
Your package bundles quazip, which is already in Fedora. Please delete it in
the prep section and make your package use the system's version.
I missed this! I'll take care of it.
Usually the files section starts with the main package and not with a
sub-package.
Okay. I'll rearrange the spec file.
Harmonize on either using %{buildroot} or $RPM_BUILD_ROOT.
Done.
Please pay attention to the translations. See
http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
The description of the data package is wrong. It doesn't contain architecture
independent documentation, but data. Besides that, you should make the
sub-package Noarch, to yield an advantage.
Okay.
The package includes some tests. Can you run them in a check section?
Okay.
License and readme file belong to the main package. The install file should not
be included.
Okay.
I'll rebuild the spec with the changes and upload a new srpm soon.
Thanks again!
Ankur
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.