https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #16 from Fabio Valentini <decathorpe(a)gmail.com> ---
(In reply to Marc-Andre Lureau from comment #15)
(In reply to Fabio Valentini from comment #14)
> > error: no matching package named `once_cell` found
> > location searched: registry `crates-io`
>
> You need to run `%cargo_generate_buildrequires` inside the "ffi"
directory,
> as far as I can tell, i.e.
>
> """
> %generate_buildrequires
> cd ffi
> %cargo_generate_buildrequires
> cd ..
> """
ok
You know, I *intentionally* wrote "cd ffi" and "cd .." instead of
pushd / popd
...
Because pushd and popd break the %generate_buildrequires script, since they
print things to stdout (which is then interpreted as a dependency).
>
> It is *very* unusual to have the "workspace root" in a subpackage of the
> actual "project root" ... but that's an upstream problem.
We could eventually package the rust-rutabaga-gfx first, modify the -ffi and
compile against it. Is that really preferable?
No. That's fine. I just wanted to note that the upstream directory layout is
certainly "a choice" (a very weird one), which makes it a bit weird to build
with cargo.
>
> ===
>
> And there's a warning because you now patch to set both package.license
> *and* package.license-file:
>
> > warning: /builddir/build/BUILD/rutabaga-gfx-20230913/Cargo.toml: only one of
`license` or `license-file` is necessary
> > `license` should be used if the package license can be expressed with a
standard SPDX expression.
> > `license-file` should be used if the package uses a non-standard license.
> > See
https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-l...
for more information.
hmm, I'll drop license-file in the patch then.
Thanks, the license patch looks good to me.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...