https://bugzilla.redhat.com/show_bug.cgi?id=1859414
--- Comment #10 from Pavel Valena <pvalena(a)redhat.com> ---
Strange, how the `rubygems-devel` got mixed in between `rubygems()`
then? Does the sort ignore brackets?
Yes, it seems strange to me as well. I should have probably used `sort -h`
Still, I would prefer to keep the default BRs on top, but that is my
preference, I'll leave it up to you.
Right, I don't mind either way, so I've moved them to the top. Changes compared
to gem2rpm-generated file:
https://gist.github.com/032d0ca905e984a9f92b9b56370dd8a8
Not sure I understand what you mean by this? rubygem-rails depends on
rubygem-actionmailbox
Yes, but the dependency is runtime-only (no BR). But you're right, it's better.
I am not saying there is benefit in duplication, but shuffling the
directory on the disk does not help either. Of course I would prefer symlink if that was
possible, but otherwise I think the `cp` has the closest behavior to `mv`. May be it could
help if linked just the files, but that is OT for this review (unless you want to
experiment a bit ;) ) ...
We could hardlnink / bind / mount, but that could potentialy complicate or
destabilze the test suite; and I don't want add bash code just for doing
symlinks. Let's leave that for upstream to solve first.
Thanks for the review!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component