Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705585
Thomas Spura <tomspur(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #8 from Thomas Spura <tomspur(a)fedoraproject.org> 2011-06-17 01:54:55 EDT
---
Sorry, I somehow missed comment #6...
Thanks for the ping.
I'm ok with your "Requires will have to go the other way; linbox-devel must R
fflas-ffpack-devel". Please make a note in the spec file about this, so nobody
wonders about the decision to leave R on linbox-devel away.
Adding the %check section now doesn't hurt. It seems, some tests are not
running, right now, but are also not failing:
"""
GIVARO version 3.4.0 or greater (<3.5) is required for some tests in this
library.
"""
->
"""
PASS: test-charpoly
PASS: test-compressQ
==================
All 2 tests passed
==================
"""
But if you want to add them later, it's fine too (adding them now, is only a
"SHOULD" on my review list :) )
#####################################################################
APPROVED
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.