Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755890
--- Comment #17 from Richard Shaw <hobbes1069(a)gmail.com> 2011-12-08 09:28:50 EST
---
> 2. Do we need python2 if we're building with python3?
>
> If not change your BuildRequires to:
>
> %if 0%{?with_python3}
> BuildRequires: python3-devel
> %else
> BuildRequires: python2-devel
> %endif # if with_python3
I believe the original way is the correct way. At least every package I've seen
does not conditionalize the BR: python2-devel and it is this way in the
guidelines as well
http://fedoraproject.org/wiki/Packaging:Python
I think the section of the python guidelines you're referring to are if you're
building for *BOTH* python2 and python3[1]. I believe in your case it's an
either/or, so it shuold be conditionalized.
Let me know if that is not the case.
BTW also fixed the DEFAULT_SNAPFILE bug (this will be shipped in the
first
release after this RPM gets into Fedora, though you can manually apply the fix
for now if you want)
https://github.com/movitto/snap/commit/7a53119b1d5bd048a4ddfbdf5bf9962f3d...
Is there any reason not to include this fix as a patch?
Richard
[1]
http://fedoraproject.org/wiki/Packaging:Python#Building_more_than_once
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.