https://bugzilla.redhat.com/show_bug.cgi?id=1117025
--- Comment #1 from František Dvořák <valtri(a)civ.zcu.cz> ---
Issues or changes for consideration:
1) new version of joiner is available (0.3.3)
2) (cosmetic) you can consider using unified way of excluding files (replacing
"rm .%{gem_instdir}/%{gem_name}.gemspec" by %exclude macro?)
3) (cosmetic) you can consider using %license macro for license file
4) (future work) I think combustion gem requires bundler. Removing bundler from
spec_helper.rb may break things, or there will be needed some way of disabling
bundler in combustion?
But it is not used now anyway, so it is not needed neither for build nor
passing the review. :-)
5) (question) there is not used "require 'active_record'" anywere in
joiner
sources, but I guess it's OK (developers using joiner will require rails or
activerecord anyway?)
<mock-chroot>[root@forkys /]# ruby -e "require 'joiner'"
/usr/share/gems/gems/joiner-0.3.0/lib/joiner/joins.rb:2:in `<class:Joins>':
uninitialized constant ActiveRecord (NameError)
from /usr/share/gems/gems/joiner-0.3.0/lib/joiner/joins.rb:1:in `<top
(required)>'
from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in
`require'
from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in
`require'
from /usr/share/gems/gems/joiner-0.3.0/lib/joiner.rb:6:in `<top
(required)>'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component