Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=820361
--- Comment #11 from jiri vanek <jvanek(a)redhat.com> 2012-05-14 11:25:25 EDT ---
(In reply to comment #10)
Updated files:
Spec URL:
http://omajid.fedorapeople.org/java-atk-wrapper/java-atk-wrapper.spec
SRPM URL:
http://omajid.fedorapeople.org/java-atk-wrapper/java-atk-wrapper-0.30.4-1...
(In reply to comment #8)
> ===summary===
>
> ==must be fixed:==
> =MUST: The package MUST successfully compile and build into binary rpms on at
> least one primary architecture. [7]
> *fail* there is missing BUildRequires
Fixed.
thanx!
> ==should be fixed if there is will and reason to do so:==
> =rpmlint technic warning
> =MUST: Permissions on files must be set properly. Executables should be set
> with executable permissions, for example. [15]
> *fail* It looks like shared library have 775, I suggest to exactly specify
> permissions in specfile (however, default 775 are usable), so this can be
> considered as ok
I cant reproduce this (either locally or on koji). Please try this scratch
build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4070482
Very well.. In this rpm the issue is not presented. On my mock build on f16 for
f17 it IS presented. However the koji is significant, and also execute-ability
is kept so I'm ok here.
> =SHOULD: your package should contain man pages for
binaries/scripts. If it
> doesn't, work with upstream to add them where they make sense.[32]
> No manual pages. In this case I miss some more info how to enable this (for ANY
> jvm)
I am not sure if man pages are appropriate for a package without executables. I
have added a fedora-specific README though.
> =SHOULD: The reviewer should test that the package functions as described. A
> package should not segfault instead of running, for example.
> I have tried, and I was unable to verified. I have included ptisnovs a openjdk
> QA to test this. But we have failed to verify even old java-access-bridge
> If you have any more ideas how to enable it and verify it I will be very glad
I have added the instructions to the README.fedora file. I have also convinced
Pavel (ptisonvs) that this (mostly) works on irc :)
I have noticed;)
Thanx for read-me. It was exactly what I have been missing.
> =include and verify with openjdk7
I will post a patch to java-1.7.0-openjdk separately.
Sure :)
Please consider f17 branch also. I think it is worthy to have this package
before f18 for debugging purposes of people around openjdk.
Tahnx for package!
APPROVED
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.