https://bugzilla.redhat.com/show_bug.cgi?id=1626134
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- LGPL-3.0 is not a valid license shorthand. See valid list here:
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
License: LGPLv3
- Group is not used in Fedora. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- BuildRoot: %{_tmppath}/%{name}-%{version}-build is not used anymore
- Not useful as it is the default already:
%defattr(-,root,root)
- The license file must be installed with %license, not %doc:
%license LICENSE.txt
%doc README.md
- This is not really the way to do it:
%dir %{_datadir}/icons/hicolor
%dir %{_datadir}/icons/hicolor/128x128
%dir %{_datadir}/icons/hicolor/128x128/apps
%{_datadir}/icons/hicolor/128x128/apps/space.fips.Fips.png
%dir %{_datadir}/icons/hicolor/256x256
%dir %{_datadir}/icons/hicolor/256x256/apps
%{_datadir}/icons/hicolor/256x256/apps/space.fips.Fips.png
%dir %{_datadir}/icons/hicolor/scalable
%dir %{_datadir}/icons/hicolor/scalable/apps
%{_datadir}/icons/hicolor/scalable/apps/space.fips.Fips.svg
Just use:
%{_datadir}/icons/hicolor/*/apps/space.fips.Fips.*
And then to own the icons directories, depend on hicolor-icon-theme:
Requires: hicolor-icon-theme
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component