https://bugzilla.redhat.com/show_bug.cgi?id=1553835
Ben Rosser <rosser.bjr(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|nobody(a)fedoraproject.org |rosser.bjr(a)gmail.com
Flags| |fedora-review?
--- Comment #2 from Ben Rosser <rosser.bjr(a)gmail.com> ---
Hi Sergey,
I was planning to submit a review ticket for this but hadn't gotten to it. I'm
happy to review it for you. :)
A few immediate thoughts:
1) It may just be personal preference, but I would suggest Providing "utop", as
this is both a library and application package. (I was going to name the
package "utop" and provide ocaml-utop).
2) If you BuildRequires: opam-installer, you can use the following to install:
export OCAMLFIND_DESTDIR=%{buildroot}%{_libdir}/ocaml
mkdir -p $OCAMLFIND_DESTDIR
jbuilder install --prefix %{buildroot}%{_prefix}
This doesn't *completely* do the right thing; I've found that it puts man pages
in the wrong place, for instance. But it's a bit better than manually copying
over all the files.
3) You likely need to Require emacs-filesystem, as I believe
{_emacs_sitelispdir} will otherwise not be owned.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component