https://bugzilla.redhat.com/show_bug.cgi?id=1728300
--- Comment #2 from Xavier Bachelot <xavier(a)bachelot.org> ---
Thanks for the review.
(In reply to Robert-André Mauchin from comment #1)
- Make a separate subpackage for the doc
I've removed 2 big files which are not really relevant. This saves 5 MB.
Also, I've created a devel-doc sub-package holding the internal perl modules
documentation (all man3 files). This saves 624 KB.
Does one still need the -doc then ?
[!]: If the package is under multiple licenses, the licensing
breakdown
must be documented in the spec.
Actually, the License: tag is wrong due to the many bundled fonts and
javascripts.
And as what is unbundled depends on the distro/release, it is not that easy to
advertise the correct one.
I've started to look at making this better, but it still needs work, so not
fixed yet.
While reviewing the licences, I also found out the package providing jquery-ui
has an incorrect license tag:
https://bugzilla.redhat.com/show_bug.cgi?id=1729965
[x]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config(noreplace,missingok)
%attr(-,sympa,sympa) /etc/sympa/auth.conf %config(noreplace,missingok)
%attr(-,sympa,sympa) /etc/sympa/charset.conf
%config(noreplace,missingok) %attr(-,sympa,sympa)
/etc/sympa/crawlers_detection.conf %config(noreplace,missingok)
%attr(-,sympa,sympa) /etc/sympa/create_list.conf
%config(noreplace,missingok) %attr(-,sympa,sympa)
/etc/sympa/edit_list.conf %config(noreplace,missingok)
%attr(-,sympa,sympa) /etc/sympa/nrcpt_by_domain.conf
%config(noreplace,missingok) %attr(-,sympa,sympa)
/etc/sympa/topics.conf %config(noreplace,missingok)
%attr(-,sympa,sympa) /etc/sympa/mime.types
%config(noreplace,missingok) %attr(-,sympa,sympa)
/etc/sympa/sympa.wsdl %config(missingok) %attr(-,sympa,sympa)
/etc/sympa/data_structure.current_version
The files marked as %config(noreplace,missingok) are optional. An admin may
want to remove them if he uses them un-modified from the defaults that live in
/usr/share/sympa/default.
I'm confused with the 'No (noreplace) in %config(noreplace,missingok)'
comment.
Can you explain ? Or is that just rpmlint/fedora-review being picky ?
If one or the other needs to be removed, I'd remove ignoremissing rather than
noreplace.
[!]: Large data in /usr/share should live in a noarch subpackage if
package
is arched.
Note: Arch-ed rpms have a total of 19875840 bytes in /usr/share
sympa-6.2.44-1.fc31.x86_64.rpm:19875840
Not fixed yet.
I'll provide updated spec and SRPM when I've adressed all of your remarks.
Thanks again.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component