https://bugzilla.redhat.com/show_bug.cgi?id=1756907
--- Comment #3 from Jeremy Bertozzi <jeremy.bertozzi(a)gmail.com> ---
(In reply to Ege Güneş from comment #2)
This is a informal review, I'm not in packagers group.
Issues:
=======
- There are installation errors (see below).
- The package has tests, run them in `%check`.
- You defined `Summary` twice.
- I think you should move `%description` and `%package` sections under
`Requires`.
- Install fails because upt is not available (I explicitly added the Requires
tag, thanks to your comment, even if the Python dependency generator did its
job)
- The tests will also fail as it also upt. I have added some conditional tests
in my SPECs (to disable them until all dependencies are in Fedora
repositories).
- Defined twice because of sub-package for python3, not sure if I could remove
it (see the example from the guideline [1])
- Correct, I modified all my SPEC to have something more coherent
Thank you for your time!
[1]
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_exampl...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component