https://bugzilla.redhat.com/show_bug.cgi?id=1264713
Ralf Corsepius <rc040203(a)freenet.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rc040203(a)freenet.de
Assignee|nobody(a)fedoraproject.org |rc040203(a)freenet.de
--- Comment #7 from Ralf Corsepius <rc040203(a)freenet.de> ---
This package has quite a few issues.
- Enable building debug packages.
i.e. remove %global debug_package %{nil}
- Making is non-verbose.
Please append V=1 to the make-call, i.e.
make %{?_smp_mflags} V=1
- libdir is not being honored:
One way to achieve this, is this
%cmake -DCMAKE_INSTALL_LIBDIR=%{_libdir}
and to remove
mv %{buildroot}/usr/lib %{buildroot}%{_libdir}
- As you have split the package into a main package (uchardet) and a *-libs
package, the main should not contain the libs (they already are in *-libs).
Please remove
%{_libdir}/lib%{name}.so.*
from the main-package's %files
- The libs are contained in *-libs.
=> The %post/%postun scriptlets need to be added to the *-libs package and not
to the main package.
Please change %post/%postun into
%post libs -p /sbin/ldconfig
%postun libs -p /sbin/ldconfig
- The package internally uses 0.0.1 as version number and not 0.0.0:
cf. CMakeLists.txt:
...
set (UCHARDET_VERSION_MAJOR 0)
set (UCHARDET_VERSION_MINOR 0)
set (UCHARDET_VERSION_REVISION 1)
...
Change your package version accordingly.
- There is a bug in upstream's PACKAGE_NAME.
cf. CMakeLists.txt:
set (PACKAGE_NAME opencc)
This likely should be "uchardet"
This doesn't seem to have an impact on the package, but please consider
contacting upstream about it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component