https://bugzilla.redhat.com/show_bug.cgi?id=1611829
--- Comment #17 from Marc-Andre Lureau <marcandre.lureau(a)redhat.com> ---
- remove the duplicated "License: BSD" lines, the top-level one is enough
- no need to duplicate %doc & %license for each pacakge
- use regular section order, %files come just before %changelog (thanks!)
- since the package builds with python3, why not BR python3 and remove BR
python2-twisted?
- %post -> %post selinux ?
Why do you make it a seperate (required) -selinux package, and not include
the policy in swtpm package directly?
What is the status of selinux policy review ?
- I suggest to remove the top-level comment: # --- swtpm rpm-spec ---
- dist'ing libswtpm_libtpms.so in -devel isn't useful if you don't provide a
header & stable API to use it.
- it is a good idea to add a link to this BZ in the changelog
my attempt so far:
https://paste.fedoraproject.org/paste/zkHXboAJJnggRwMUo0dBlA
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component