https://bugzilla.redhat.com/show_bug.cgi?id=1717389
--- Comment #2 from Miro Hrončok <mhroncok(a)redhat.com> ---
Several notes:
1. consider naming this pyproject-rpm-macros. there are hundreds of macro
kinds, not just RPM macros
2. please don't tar the sources, keep them separate, see python-rpm-macros as
an example - they will be editable in src.fp.o git directly
3. release number and %changelog are inconsistent, I suggest versioning this
with 0 and only bump release
4. there are limits for %description length, have you try using rpmlint? also
the text is quite unfortunate, rawhide is not for testing.
5. "Macros using pep517 to building python packages" -> "RPM macros for
PEP 517
Python packages"
6. why "echo %{expand: %{version}}"?
7. there are macros for /usr/lib/rpm/macros.d/, see python-rpm-macros as an
example
8. the copyright in LICENSE is a bit unfortunate, can this be
"pyproject-rpm-macros contributors" instead of just you? I remember writing an
initial draft of those. also given the Fedora Project Contirbutor Agreement I
don't think we need the LICENSE file, see python-rpm-macros as an example
9. sed -i -e 's/pip/rpm/g' %{buildroot}%{python3_sitelib}/*.dist-info/INSTALLER
-- what about sitearch?
10. the README seems to still have notes from me to you, such as "XXX what?" --
do you consider this a shippable thing?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component