Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=732216
Dan Callaghan <dcallagh(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review+
--- Comment #20 from Dan Callaghan <dcallagh(a)redhat.com> ---
(In reply to comment #19)
(In reply to comment #18)
> You should remove the %clean section, and rm -rf %buildroot at the top of
> %install, and %defattr, and BuildRoot tag, as they are not needed. You can
> also remove the Group tags.
We may support EPEL 5 in the future, and my RPMs are rebuilt on EL5 in the
wild, so I've made a habit of maintaining RHEL5 spec compatibility in all
nodejs RPMs for now.
This was also discussed with another reviewer in bug 891194.
No worries.
> It might be more conventional to call the docs subpackage -doc
(instead of
> -docs) but in the guidelines that's given as a recommendation, not a
> requirement, so I'll leave it up to you.
>
> Complete review checklist is pasted below, there are only two blocking
> issues:
> * /usr/share/coffee-script/lib/coffee-script/parser.js should not be
> executable
> * LICENSE needs to be moved from -docs to -common (maybe README as well), so
> that it is always installed
All fixed.
Spec:
http://patches.fedorapeople.org/node_modules/coffee-script.spec
SRPM:
http://patches.fedorapeople.org/node_modules/coffee-script-1.4.0-4.fc18.src.
rpm
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4948144
Nice work! Approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=J2t6WH0wUM&a=cc_unsubscribe