https://bugzilla.redhat.com/show_bug.cgi?id=1904172
Michel Alexandre Salim <michel(a)michel-slm.name> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |michel(a)michel-slm.name
Assignee|nobody(a)fedoraproject.org |michel(a)michel-slm.name
Doc Type|--- |If docs needed, set a value
Flags| |fedora-review?
--- Comment #1 from Michel Alexandre Salim <michel(a)michel-slm.name> ---
Taking this review. Some initial notes:
- the BuildRequires on systemd is probably overkill. you can use
systemd-rpm-macros (for %{_unitdir}) and `mkdir -p` it in %install before
copying a file there. At runtime you can assume systemd is installed
- Other BRs are fine (git is used for %autosetup -S git)
- installing files do not preserve permissions, both the additional files you
install as well as the ones by `make install`
- you're not using %make_install, but upstream Makefile doesn't support
DESTDIR and INSTALL which the macro assumes. if you submit a patch to upstream,
it might be worth making it support the variables %make_install uses
These are not blockers though, but consider making the first change before
importing your package, it will speed up the build a bit by pulling in less
dependencies.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component