Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620826
Stanislav Ochotnicky <sochotni(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|177841(FE-NEEDSPONSOR) |
--- Comment #2 from Stanislav Ochotnicky <sochotni(a)redhat.com> 2010-08-04 08:18:52
EDT ---
Thanks for your comments.
(In reply to comment #1)
Just some comments (I'm no sponsor anyway):
I don't need a sponsor, I have 20+ packages in Fedora already, but mostly java
and this was my first python package from scratch. I guess I confused you when
I said "first python package" :-) Removing FE_NEEDSPONSOR.
- How do you get GPLv3+?
Website says LGPL, There is a LGPLv2+ license and no headers on the first
sign.
Duh, I was sure I fixed that. I was actually confused because setup.py states
GPLv2.1 as a license while LICENSE.txt says LGPLv2.1. I re-reviewed all files
and it's a mix in the end. I'll get in touch with upstream to clarify this, but
I guess it is supposed to be LGPLv2.1.
- You could add a %check section for running the testsuite.
checks fail in mock so I didn't put them in. I "fixed" this by adding
commented
out check run with explanation why it was disabled.
No issues beyond that, your %files section looks nice, not much are
so explicit
like you (how it should be done).
Thanks for all the comments. Really appreciated.
New release:
Spec URL:
http://sochotni.fedorapeople.org/packages/python-icalendar.spec
SRPM URL:
http://sochotni.fedorapeople.org/packages/python-icalendar-2.1-2.fc13.src...
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.