https://bugzilla.redhat.com/show_bug.cgi?id=2168255
--- Comment #3 from Neal Gompa <ngompa13(a)gmail.com> ---
Some initial spec review feedback:
Version: 1.4.0
Release: 1%{?selint_pre_ver:.%{selint_pre_ver}}%{?dist}
Please use modern pre-release versioning, as it makes automation much easier.
Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_ha...
License: ASL 2.0
Please use SPDX license identifiers here. In this case, it'd be
"Apache-2.0".
Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidel...
BuildRequires: autoconf autoconf-archive automake bison check
check-devel flex gcc help2man libconfuse libconfuse-devel uthash-devel
Please put these one per line, so that future updates make it easy to see
changes. You're also missing "make" as a build dependency. You also
don't need
"check" as a dependency when "check-devel" pulls it in.
# pkgconfig
Requires: libconfuse
%if 0%{?fedora} || 0%{?rhel} >= 8
Requires: check
%endif
None of this should be needed, as dependencies are automatically generated.
Please drop this.
%setup -q -n %{name}-%{version}
%autosetup -p 1
This is very redundant. Drop the "%setup" line.
%if 0%{?rhel} == 7
%{configure} --without-check
%else
%{configure}
%endif
You should be able to just use "%configure" here, since you always have check
available in the build environment (even in EL7).
Looking at the sources, you probably want to conditionalize the inclusion of
"BuildRequires: check-devel" and "BuildRequires: check". That may give
you the
same effect.
Also, generally as a style choice, we don't usually use curly braces here.
%{make_build}
Generally as a style choice, we don't usually use curly braces here.
%{make_install}
Generally as a style choice, we don't usually use curly braces here.
%check
Your check section is empty. You aren't running tests.
Maybe "%make_build check" would work in this section?
%{_mandir}/man1/selint.1.gz
This should be "%{_mandir}/man1/selint.1*" as we cannot assume that man pages
will remain gzip compressed.
Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2168255