https://bugzilla.redhat.com/show_bug.cgi?id=977208
--- Comment #6 from Roman Mohr <roman(a)fenkhuber.at> ---
(In reply to Renich Bon Ciric from comment #5)
(In reply to Roman Mohr from comment #4)
> It is better to name the tar.gz like %{name}-%{version}.tar.gz as in the
> patch ( see point "Source0" in
>
http://fedoraproject.org/wiki/
> How_to_create_an_RPM_package#SPEC_file_overview). Otherwise your tar.gz
> might override other tar.gz's in your SOURCES directory which are also not
> properly named.
>
> The patch works for me. Did you place the source tar.gz in your
> ~/rpmbuild/SOURCES directory?
Yes; I did. The thing is that the package should be named php-phalcon for 2
reasons:
- Fedora frameworks and pecl libs are named php-<name>
- The package is named cphalcon; but the project is called Phalcon. Believe
me; I asked the author about it.
That's ok, but that is not what I meant. I just said that I think it is a good
idea to name the source tarball like the rpm package.
So, your script works fine with cphalcon as a name. Not with
php-phalcon as
a name.
Well that is not correct. If you download the tarball (after patching the spec
file) via "spectool -g php-phalcon.spec" you will get a source file called
php-phalcon-1.2.0.tar.gz (see
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL...):
----> Source0:
https://github.com/%{_name}/c%{_name}/archive/%{version}.tar.gz#/%{name}-...
So after patching, download the source tarball via spectool and put it into
rpmbuild/SOURCES or rename your sources there to "php-phalcon-1.2.0.tar.gz".
But still, when you extract it, the extracted folder is called "cphalcon-1.2.0"
and this is why I apply this to %%setup:
----> %setup -q -n c%{_name}-%{version}
> After patching the spec file I tested it with something like
this:
>
> spectool -g php-phalcon.spec
> mock -r fedora-rawhide-x86_64 --buildsrpm --spec=php-phalcon.spec
> --sources=. --resultdir=.
> mock -r fedora-rawhide-x86_64 --no-clean --no-cleanup-after --resultdir=.
> php-phalcon-1.2.0-1.fc20.src.rpm
I could've patched it wrongly. I did patch orig file.patch
Thank you for your interest! ;)
I hope I will find some time tomorrow ( I cant promise) for a proper review.
Cheers,
Roman
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=J7u0EL6zmQ&a=cc_unsubscribe