https://bugzilla.redhat.com/show_bug.cgi?id=1773720
--- Comment #8 from Brandon Perkins <bperkins(a)redhat.com> ---
(In reply to Brandon Perkins from comment #6)
> [ ]: Each %files section contains %defattr if rpm < 4.4
> Note: %defattr present but not needed
Fixed with 1.2.4-6.
Fixed, but there is no line for this in the new review report.
$ grep %defattr SPECS/golang-github-haproxytech-dataplaneapi.spec
> [ ]: Spec use %global instead of %define unless justified.
> Note: %define requiring justification: %define gorepo dataplaneapi,
> %define haproxy_user haproxy, %define haproxy_group %{haproxy_user},
> %define haproxy_homedir %{_localstatedir}/lib/haproxy
Fixed with 1.2.4-6.
Fixed:
[x]: Spec use %global instead of %define unless justified.
$ grep -E "%(global|define)" SPECS/golang-github-haproxytech-dataplaneapi.spec
%global gorepo dataplaneapi
%global haproxy_user haproxy
%global haproxy_group %{haproxy_user}
%global haproxy_homedir %{_localstatedir}/lib/haproxy
%global _hardened_build 1
%global goipath
github.com/haproxytech/dataplaneapi
%global common_description %{expand:
%global golicenses LICENSE
%global godocs README.md CONTRIBUTING.md
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component