https://bugzilla.redhat.com/show_bug.cgi?id=2180418
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|nobody(a)fedoraproject.org |zbyszek(a)in.waw.pl
Status|NEW |ASSIGNED
CC| |zbyszek(a)in.waw.pl
--- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
I think the package name should be just 'input-remapper'. The
guidlines [1] say:
Packages that primarily provide applications, services or any kind of
executables
SHOULD be named according to the general Fedora naming guidelines (e.g. ansible).
Consider adding a virtual provide according to Library naming above (e.g.
python3-PROJECTNAME),
if it would help users find the package.
[1]
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_applic...
The description should be wrapped to <= 80 columns, right now it's 67.
It'd be nice to add some general information how the package works
(by injecting input system events?).
Release: 1%{?dist}
%autorelease and %autochangelog are
now the recommended defaults
(
https://pagure.io/packaging-committee/pull-request/1255 was merged).
%__mv
/usr//bin/systemctl
%__install
Just 'mv', 'systemctl', 'install' are fine. The
guidelines do NOT say that
macros should be used, and there is really no reason to circument $PATH
in a subset of cases.
But I don't think the call to 'systemctl start' is OK. The guidelines
say that presets should be used [2]. So I think you should either:
- drop the call to systemctl, or
- move it to %posttrans and check that 'systemctl is-enabled
input-remapper.service'
returns 'enabled' and only start the service in that case. (This would mean
that
the presets are respected, but the service is available immediately after
package installation if enabled.)
Oh, and packages are not allowed to include presets [2].
So %SOURCE1 must be dropped.
You can open a ticket or pull request to add the service to presets in
fedora-release.
[2]
https://docs.fedoraproject.org/en-US/packaging-guidelines/DefaultServices/
BuildRequires: git
Is this necessary?
%systemd_postun %{up_name}.service
%systemd_postun_with_restart
would be better. Unless the service breaks on
restart,
it should be restarted on upgrades.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2180418