Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193
--- Comment #9 from Eduardo Echeverria <echevemaster(a)gmail.com> ---
Wesley:
Sorry for delay, I had a busy few days
(In reply to comment #7)
Are good news !!
About versioning.
- Current development version is 0.2.0
- rev is in this case 734
therefore, the versioning should be: 0.2.0-0.1.20130124bzr734
and the release number increment every time you make changes in the spec:
e.g.
0.2.0-0.2.20130124bzr734
0.2.0-0.3.20130124bzr734
and so on
in the spec:
%global bzrid 734
%global checkout 20130124bzr%{bzrid}
Name: plank
Version: 0.2.0
Release: 0.1.%{checkout}%{?dist}
Source0: plank-%{version}.%{bzrid}.tar.xz
About @shared-lib-calls-exit
this is no review blocker, .But it is worth to inform the upstream about that.
(and fix it soon)
Let's review
rpmlint plank plank-devel plank-debuginfo
plank.x86_64: W: spelling-error Summary(en_US) docky -> dock, docks, dorky
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/libgthread-2.0.so.0
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/librt.so.1
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/libatk-1.0.so.0
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/libcairo-gobject.so.2
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/libpthread.so.0
See
http://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-d...
objdump -p libplank.so.0.0.0 | grep NEEDED
NEEDED libm.so.6
NEEDED libgthread-2.0.so.0
NEEDED librt.so.1 *
NEEDED libbamf3.so.0
NEEDED libwnck-3.so.0
NEEDED libgtk-3.so.0
NEEDED libgdk-3.so.0
NEEDED libatk-1.0.so.0 *
NEEDED libgio-2.0.so.0
NEEDED libpangocairo-1.0.so.0
NEEDED libgdk_pixbuf-2.0.so.0
NEEDED libcairo-gobject.so.2 *
NEEDED libpango-1.0.so.0
NEEDED libcairo.so.2
NEEDED libgee.so.2
NEEDED libgobject-2.0.so.0
NEEDED libglib-2.0.so.0
NEEDED libX11.so.6
NEEDED libpthread.so.0 *
NEEDED libc.so.6
- (nonblocker) You might mention to upstream the various warnings
Drawing/DockSurface.vala:366.32-366.51: warning: GLib.Thread.create has been
deprecated since 2.32. Use new Thread<T> ()
Drawing/DockSurface.vala:375.10-375.29: warning: GLib.Thread.create has been
deprecated since 2.32. Use new Thread<T> ()
Drawing/DockSurface.vala:492.32-492.51: warning: GLib.Thread.create has been
deprecated since 2.32. Use new Thread<T> ()
Drawing/DockSurface.vala:515.10-515.29: warning: GLib.Thread.create has been
deprecated since 2.32. Use new Thread<T> ()
Drawing/DrawingService.vala:54.49-54.77: warning:
GLib.FILE_ATTRIBUTE_THUMBNAIL_PATH has been deprecated since vala-0.16. Use
FileAttribute.THUMBNAIL_PATH
Factories/AbstractMain.vala:271.4-271.15: warning: `null' incompatible with
return type `string[]`
return null;
^^^^^^^^^^^^
Items/ApplicationDockItem.vala:442.52-442.87: warning:
GLib.FILE_ATTRIBUTE_STANDARD_CONTENT_TYPE has been deprecated since vala-0.16.
Use FileAttribute.STANDARD_CONTENT_TYPE
Items/FileDockItem.vala:294.52-294.79: warning:
GLib.FILE_ATTRIBUTE_STANDARD_NAME has been deprecated since vala-0.16. Use
FileAttribute.STANDARD_NAME
Items/FileDockItem.vala:295.8-295.40: warning:
GLib.FILE_ATTRIBUTE_STANDARD_IS_HIDDEN has been deprecated since vala-0.16. Use
FileAttribute.STANDARD_IS_HIDDEN
Items/FileDockItem.vala:296.8-296.37: warning:
GLib.FILE_ATTRIBUTE_ACCESS_CAN_READ has been deprecated since vala-0.16. Use
FileAttribute.ACCESS_CAN_READ
DockItems.vala:388.42-388.69: warning: GLib.FILE_ATTRIBUTE_STANDARD_NAME has
been deprecated since vala-0.16. Use FileAttribute.STANDARD_NAME
DockItems.vala:388.79-388.111: warning: GLib.FILE_ATTRIBUTE_STANDARD_IS_HIDDEN
has been deprecated since vala-0.16. Use FileAttribute.STANDARD_IS_HIDDEN
DockItems.vala:224.77-224.104: warning: GLib.FILE_ATTRIBUTE_STANDARD_NAME has
been deprecated since vala-0.16. Use FileAttribute.STANDARD_NAME
DockItems.vala:224.114-224.146: warning: GLib.FILE_ATTRIBUTE_STANDARD_IS_HIDDEN
has been deprecated since vala-0.16. Use FileAttribute.STANDARD_IS_HIDDEN
Services/WindowControl.vala:124.3-124.41: warning: method
`Plank.Services.Windows.WindowControl.has_minimized_window' never used
public static bool has_minimized_window (Bamf.Application app)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Services/WindowControl.vala:166.3-166.50: warning: method
`Plank.Services.Windows.WindowControl.get_windows' never used
public static ArrayList<Bamf.Window> get_windows (Bamf.Application app)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Services/WindowControl.vala:237.3-237.26: warning: method
`Plank.Services.Windows.WindowControl.focus' never used
public static void focus (Bamf.Application app)
^^^^^^^^^^^^^^^^^^^^^^^^
Services/WindowControl.vala:294.3-294.29: warning: method
`Plank.Services.Windows.WindowControl.minimize' never used
public static void minimize (Bamf.Application app)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Services/WindowControl.vala:303.3-303.28: warning: method
`Plank.Services.Windows.WindowControl.restore' never used
public static void restore (Bamf.Application app)
^^^^^^^^^^^^^^^^^^^^^^^^^^
Services/WindowControl.vala:479.3-479.47: warning: method
`Plank.Services.Windows.WindowControl.get_easy_geometry' never used
public static Gdk.Rectangle get_easy_geometry (Wnck.Window w)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
- Source file missing in debuginfo package:
cpio: plank-0.2.0.734/lib/AbstractMain.c: Cannot stat: No such file or
directory
cpio: plank-0.2.0.734/lib/AnimatedRenderer.c: Cannot stat: No such file or
directory
cpio: plank-0.2.0.734/lib/ApplicationDockItem.c: Cannot stat: No such file or
directory
cpio: plank-0.2.0.734/lib/Color.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/CompositedWindow.c: Cannot stat: No such file or
directory
cpio: plank-0.2.0.734/lib/DockItem.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/DockItemPreferences.c: Cannot stat: No such file or
directory
cpio: plank-0.2.0.734/lib/DockSurface.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/DockTheme.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/DockWindow.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/DrawingService.c: Cannot stat: No such file or
directory
cpio: plank-0.2.0.734/lib/Factory.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/FileDockItem.c: Cannot stat: No such file or
directory
cpio: plank-0.2.0.734/lib/HoverTheme.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/HoverWindow.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/ItemFactory.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/Logger.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/Matcher.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/Paths.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/PlankDockItem.c: Cannot stat: No such file or
directory
cpio: plank-0.2.0.734/lib/PoofWindow.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/Preferences.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/System.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/Theme.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/TitledSeparatorMenuItem.c: Cannot stat: No such file
or directory
cpio: plank-0.2.0.734/lib/TransientDockItem.c: Cannot stat: No such file or
directory
cpio: plank-0.2.0.734/lib/Unity.c: Cannot stat: No such file or directory
cpio: plank-0.2.0.734/lib/WindowControl.c: Cannot stat: No such file or
directory
Consider fix these points deal with upstream, and I'll do the formal review
Kind Regards
Eduardo
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=9Ghf4Lwbmc&a=cc_unsubscribe