https://bugzilla.redhat.com/show_bug.cgi?id=1474033
--- Comment #11 from Andrey Maslennikov <andreyma(a)mellanox.com> ---
Spec URL:
https://gist.github.com/amaslenn/3c847e0bdc063bcbb4b6507b5efbf6b9/raw/09b...
SRPM URL:
https://gist.github.com/amaslenn/3c847e0bdc063bcbb4b6507b5efbf6b9/raw/09b...
Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21224428
> Static libs moved to separate -static package. -devel depends on
it.
That is not what the guidelines suggest. Just think about it a bit. Such a dependency
defeats the purpose of moving the static libs into a _separate_ package.
Just want
to make it easier for users to get all packages required for
development.
Will removing Required from -devel be enough to comply this policy?
> Added --disable-rpath to %configure anyway.
That's a no-op, if the configure script doesn't support that option [yet]:
| configure: WARNING: unrecognized options: --disable-rpath
Missed that. Thanks,
removed. Don't see this issue anyway.
> %files
> ...
> %{_datadir}/ucx
> %exclude %{_datadir}/ucx/examples
> %{_datadir}/ucx/perftest
The first line in the quote above includes the complete %_datadir/ucx/ tree already minus
the excluded directory. Hence the last line is superfluous.
Fixed, thanks.
> Just want to have issues in spec fixed before creating actual
release.
> Can we ignore this one for a while?
You only need to keep in mind that replacing the source tarball with another release
could be a rather disruptive step during review.
Don't like it either. Hope to
fix it soon.
Btw, the build.log contains several warnings about libraries and
tools (doxygen!) it cannot find.
All of them (including doxygen) are "nice to
have", not "required". The build
is possible, it only reduces some functionality (which is OK). I added one
(libibverbs-devel) to BuildRequires, this one is important.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component