https://bugzilla.redhat.com/show_bug.cgi?id=1881482
--- Comment #4 from Petr Pisar <ppisar(a)redhat.com> ---
URL and Source0 addresses are usable. Ok.
FATAL: Source0 archive does not match an upstream:
$ sha256sum -b intel-ipp-crypto-mb-develop.zip*
4646b73d907854af7e2237162573c5665b3af91eb1cc6079b737eca4d6a637ad
*intel-ipp-crypto-mb-develop.zip
70157e23beff57cb54fb68221c2a5399d533e8fbfb2c26fdbb3c3d370905d284
*intel-ipp-crypto-mb-develop.zip.orig
The archive from a SRPM package
(70157e23beff57cb54fb68221c2a5399d533e8fbfb2c26fdbb3c3d370905d284) does not
match the upstream archive from the Source0 address
(4646b73d907854af7e2237162573c5665b3af91eb1cc6079b737eca4d6a637ad).
The Source0 address is suspicious: It's not listed among the upstream released
files <
https://github.com/intel/ipp-crypto/releases>. And the URL does depend
on a version of the RPM package. This does not allow to reproduce the archives
for different versions.
Please use a versioned URL, preferably one that is linked from the upstream
home page. If the upstream does provide release archives, use a git snapshot
identified by a commit ID as documented at
<
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git...;.
Few other notes to the spec file:
The %github_repo_url macro is not necessary. You can use %{url} macro for URL
value and define Source0 as %{url}/archive...
The Group RPM tag is obsolete. Remove them fro the spec file.
The intel-ipp-crypto-mb-devel subpackage can be defined with "%package devel"
(and "%description devel" and "%files devel"). You don't need
%rpm_name macro.
The %decripion text cannot be identical to Summary text. Use more verbose
description.
What's %{github_repo_url}/blob/develop/sources/ippcp/crypto_mb? Is this the
real upstream home page? You should base the URL value on that.
You have to build-require "make" because you explicitly execute it
(intel-crypto-mb.spec:70).
You should build-require unzip because ZIP archives are natively suppored by
rpm-build.
Remove "rm -rf %{buildroot}" from %install section. Pruning the directory is
done by default.
Build-require coreutils for the "install" tool (intel-crypto-mb.spec:74).
The %{_includedir}/internal path is not specific enough for your package.
Please move the header files under a better-named directory.
The spec file is missing a %changelog section.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component