https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
|needinfo?(dominik@greysecto |
|r.net) |
--- Comment #5 from Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net>
---
1. The manpage is dungeon(6) while the binary is called "zork". This makes the
manpage not discoverable easily. Please rename or at least add a link:
%install
...
echo ".so dungeon.6" > %{buildroot}%{_mandir}/man6/zork.6
%files
...
%{_mandir}/man6/zork.6*
2. There are tons of warnings from gcc in the build log. Some of them look
serious:
https://copr-be.cloud.fedoraproject.org/results/jflory7/zork/fedora-rawhi...
...
BUILDSTDERR: np.c:176:5: warning: array subscript -1 is outside array bounds of
'integer[40]' {aka 'int[40]'} [-Warray-bounds]
BUILDSTDERR: 176 | --outbuf;
BUILDSTDERR: | ^~~~~~~~
Please work with upstream to fix these.
3. The 'history' file could also be included as %doc. I missed that last time.
Apart from that, it looks good packaging-wise and is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component