Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=732205
Thomas Spura <tomspur(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flag| |fedora-review+
--- Comment #11 from Thomas Spura <tomspur(a)fedoraproject.org> 2011-11-03 17:50:09
EDT ---
Assuming Volker doesn't want to complete this review, as there is no comment in
2 months. (Sorry, if I was disturbing above, didn't want to interrupt in any
way.)
Review:
- name ok
- group ok
- BR ok (matter of taste, where to put, would prefer in the top)
- arch ok (doc is noarch)
- %build ok (optflags are used)
- %install ok
- %check there
- libs correctly installed
- no static libs
- %files (defattr not needed on fedora, but on el5) so ok
- $ rpmlint /home/tom/rpmbuild/SRPMS/airsched-0.1.2-1.fc15.src.rpm
/home/tom/rpmbuild/RPMS/*/airsched*
5 packages and 0 specfiles checked; 0 errors, 0 warnings.
- source match upstream:
13117047d9672cf73b59fa42e0563ce5 airsched-0.1.2.tar.bz2
- doc doesn't R the main package, but has COPYING: ok
SHOULD:
- Try to convince yourself to add proper license headers ;)
################################################################################
APPROVED
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.