Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483649
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> 2009-02-02 21:31:47 EDT
---
Review:
+ package builds in mock (rawhide i386).
koji build =>
http://koji.fedoraproject.org/koji/taskinfo?taskID=1100468
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
756b0374f889cd9c1898750dabc080f2 MooseX-Workers-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=4, Tests=16, 2 wallclock secs ( 0.01 usr 0.00 sys + 1.80 cusr 0.13
csys = 1.94 CPU)
+ Package perl-MooseX-Workers-0.04-1.fc11 ->
Provides: perl(MooseX::Workers) = 0.04 perl(MooseX::Workers::Engine)
perl(MooseX::Workers::Engine::PreforkPoe)
Requires: perl(Moose) perl(Moose::Role) perl(MooseX::AttributeHelpers)
perl(POE) perl(strict)
APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.