https://bugzilla.redhat.com/show_bug.cgi?id=2028900
--- Comment #11 from Fabio Valentini <decathorpe(a)gmail.com> ---
Looks good to me, with four minor exceptions:
1) Patch0: test-use-platform-independent-c_char-instead-of-i8.patch
2) # tests are failing on s390x
Please submit the patch for 1) upstream, and report an upstream issue for 2).
I also wonder if you could replace this:
# Some tests require the C library development files
# Not a pkgconfig dep because of tree-sitter/tree-sitter#1158
BuildRequires: libtree-sitter-devel >= 0.20
With setting INCLUDEDIR or something like that to the path of the tree-sitter
sources that are bundled with rust-tree-sitter anyway.
3) # See LICENSE.dependencies for a full list of buildroot crates and licenses
This file seems to be missing from the SRPM.
It's a nice idea to put this into separate file, though. I might steal that for
some of my packages.
You might want to include the "executive summary" in the .spec file though, so
it at least contains a list of the individual licenses, if not the complete
breakdown, i.e. what's printed by `for i in $(rpm -qa | grep
"rust-.*-devel");
do rpm -q $i --qf "%{LICENSE}\n"; done | sort | uniq`.
4) Please exclude the npm / NodeJS files (npm/, emscripten-version) from
getting installed with the -devel package, and investigate whether you need the
"vendor/xterm-colors.json" file.
You can either %exclude them in the %files devel list, or add an "exclude = []"
snippet to Cargo.toml.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2028900