https://bugzilla.redhat.com/show_bug.cgi?id=2013796
--- Comment #2 from Maxwell G <redhat_bugzilla(a)gottm.anonaddy.com> ---
Hi Robby,
I have a couple pointers. Please note that this is an unofficial review; I am
also a new packager.
License: MIT
There is a trailing space at the end of this line.
BuildRequires: gcc
I don't think this is necessary. `BuildRequires: python3-devel` should be
sufficient.
%prep
%autosetup
%generate_buildrequires
%pyproject_buildrequires -t
I would add an empty line between `%autosetup` and `%generate_buildrequires`
for readability purposes.
%files
[...]
%{python3_sitelib}/saltlint/
%{python3_sitelib}/salt_lint-*.dist-info/
Instead of manually specifying these paths, you should add
`%pyproject_save_files saltlint` under `%install`, delete those two paths, and
then replace `%files` with `%files -f %{pyproject_files}`. See the Python
Packaging Guidelines for more info.
Also, it seems like building on Fedora Rawhide fails because of the broken
`python3-flake8` package. You should file a bug for that package.
```
Error:
Problem: conflicting requests
- nothing provides (python3.10dist(pyflakes) < 2.5 with
python3.10dist(pyflakes) >= 2.4) needed by python3-flake8-4.0.1-1.fc36.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest'
to use
not only best candidate packages)
```
Thanks,
Maxwell
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2013796