https://bugzilla.redhat.com/show_bug.cgi?id=1387669
--- Comment #11 from Rex Dieter <rdieter(a)math.unl.edu> ---
Sorry for the delay.
1. non-blocker/SHOULD: Response to comment #4 , I find that recommendation to
be bad in general. I'd recommend reverting that change, to properly track the
files included (*especially* the .desktop file name)
2. non-blocker/SHOULD: this dependency is odd:
Requires: application(org.kde.dolphin.desktop)
better to simply use:
Requires: dolphin
3. non-blocker/SHOULD: drop use of %make_build, prefering instead:
make %{?_smp_mflags}
for now. %make_build (and friends) are tailored to autoconf-based packages
Otherwise, fairly simple and clean package,
APPROVED
I've sponsored you into the packagers group, welcome to fedora!
Next steps:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd...
Feel free to let me know if you have any questions or need anything else.
Other development communication channels are very useful too:
https://fedoraproject.org/wiki/Communicating_and_getting_help
fedora-devel mailing list and #fedora-devel irc channels
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component