Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754698
--- Comment #4 from Ismael Olea <ismael(a)olea.org> 2011-11-22 18:48:34 EST ---
(In reply to comment #3)
fine
Yes I'm a Fedora Package Maintainer. A fairly new one :)
https://admin.fedoraproject.org/updates/user/comzeradd
That's nice :-)
Some suggestions:
* please extend the description to be more informative; now is too short; in
this sense, maybe could be significative to explicit which formats are
supported, expecially bc the Fedora packaging doesn't support some popular ones
(correct me if I'm wrong)
* accordingly, IMHO would be appropiated to add a README.Fedora with the format
support information explained
* I see idjc runs over JACK, AFAIK pulseaudio is the standard sound server in
Fedora (I really only use GNOME so I ignore the details with the other
desktop), so, is there any practical way to add the JACK integration with
Pulseaudio? Maybe something launched by a shell script or equivalent... or just
adding pulseaudio-module-jack as Requires: tag
* Have you considered to include the html documentation?
* Should be important to add a Requires: tag for icecast?
Checking list:
* Group: tag is wrong, use Applications/Multimedia
* the idjc.desktop file should include at least the AudioVideo category
* Why you remove the Application category from idjc.desktop?
PD: Completely out of this review, maybe you'll like to contrib a full featured
idjc to RPM Fusion (something like idjc-freeworld)
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.