https://bugzilla.redhat.com/show_bug.cgi?id=1707080
--- Comment #6 from Jaroslav Škarvada <jskarvad(a)redhat.com> ---
(In reply to Petr Menšík from comment #5)
(In reply to Jaroslav Škarvada from comment #3)
> (In reply to Petr Menšík from comment #2)
>
> Hopefully all fixed.
>
> > * File /usr/lib/udev/rules.d/10-osmo-fl2k.rules is shipped, but its
> > directory is not owned by package or required by the package (systemd-udev
> > or kexec-tools).
> >
> I think this is not needed [1]
>
> [1]
>
https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_the_directory_is_owned_by_a_package_which_is_not_required_for_your_package_
> to_function
In that example, it says exactly what I mentioned. You might not use
Requires, but still have to own that directory in your package. Unowned
directory is not permitted, even for optional content.
Solution: the evolution package should own the /usr/share/gtk-doc directory.
There is no need to add an explicit Requires on gtk-doc solely for the
directory ownership.
added udev requirement
Also, now we have separate libs subpackage, but it has not license
file
inside and does not depend on any package that has it. I suggest moving
%license to libs, it should be required explicitly from other subpackages
then.
added license to both, move docs to libs
Licensecheck also mentions other licenses than GPLv2+:
GNU Lesser General Public License (v2.1 or later)
-------------------------------------------------
osmo-fl2k-0.1.1-df33203d/src/getopt/getopt.c
osmo-fl2k-0.1.1-df33203d/src/getopt/getopt.h
GPL (v3 or later)
-----------------
osmo-fl2k-0.1.1-df33203d/cmake/Modules/Version.cmake
osmo-fl2k-0.1.1-df33203d/include/rds_mod.h
osmo-fl2k-0.1.1-df33203d/src/rds_mod.c
getopt seems not used by our compilation, but rds_mod is. I think Licenses:
GPLv2+ and GPLv3+ should be used.
I think it should be relicensed upstream to GPLv3+, but for now added both
Spec URL:
https://jskarvad.fedorapeople.org/osmo-fl2k/osmo-fl2k.spec
SRPM URL:
https://jskarvad.fedorapeople.org/osmo-fl2k/osmo-fl2k-0.1.1-0.3.20190501g...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component