https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #6 from Artem <ego.cordatus(a)gmail.com> ---
Created attachment 1649026
-->
https://bugzilla.redhat.com/attachment.cgi?id=1649026&action=edit
spec file
LGTM. Few minor issues:
* Please add license breakdown explanation. See example [1] spec file.
[1]
https://src.fedoraproject.org/rpms/chatterino2/blob/master/f/chatterino2....
* Add version for bundled libs:
Provides: bundled(json-parser) = 1.1.0
Provides: bundled(md5) = 1.6
* Drop 'Requires: hicolor-icon-theme' for main, non-data package. You
don't need it here.
* You can grab patch directly from GitHub
Patch2:
https://github.com/ddnet/ddnet/pull/2021.patch#/0002-add-appdata-manifest...
* Please add comment describing why necessary patch or what it doing
# Some commentary
Patch1: 0001_ddnet_Disabled-network-lookup-test.patch
* Add %{_target_platform} macros.
Check my attached patch for this and other cosmetic improvements.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component