https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Jerry James <loganjerry(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |loganjerry(a)gmail.com
--- Comment #1 from Jerry James <loganjerry(a)gmail.com> ---
The License tag is not in the correct format. See
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Lic....
Remove inappropriate executable bits in %prep. For example, some of the header
files in the img directory are marked (incorrectly) as executable.
This package bundles eigen3. To unbundle it:
- Add BuildRequires: eigen3-devel
- Add Requires: eigen3-devel
- In %prep, add something like the following (untested):
# Unbundle eigen3
rm -fr eigenlib
for fil in $(grep -Frl eigenlib .); do
sed -i
's,<eigenlib\(.*\)>,<eigen3\1>,;s,"\.\./\.\./eigenlib\(.*\)",<eigen3\1>,'
$fil
done
After unbundling, check whether that changes the license tag.
You are working much too hard in %install. Just do this:
mkdir -p %{buildroot}%{_includedir}/%{name}
cp -a apps img vcg wrap %{buildroot}%{_includedir}/%{name}
If that copies some files that should not appear in the binary RPM, then remove
them. I think that will be much more concise that what you have now.
Likewise, you are working much too hard in %files. I think this is all you
need:
%files
%license LICENSE.txt
%{_includedir}/vcglib/
The main package should be empty. You should have a subpackage created with
%package devel, so that the final package name is vcglib-devel. Look at the
way the eigen3 package does this and copy it.
It would be a good idea to run doxygen and place the resulting files in a
subpackages named docs. The PowerPoint file in the docs directory could go in
that package as well.
There are a number of C++ files with main() functions in them; e.g.,
apps/plyrefine/main.cpp. Should those be built into binaries? If so, the
resulting binaries should go in the main package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component