Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=639518
--- Comment #9 from Remi Collet <fedora(a)famillecollet.com> 2011-06-17 10:18:51 EDT
---
Sorry for the long delay.
Good work on the "split".
Final minor issues.
Licensing, See :
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Li...
So :
- gstreamer-plugins-entrans-docs doesn't requires gst-entrans (which is ok), so
you must add the license file in this sub-package.
- gstreamer-plugins-entrans could also be install alone, so must also add the
license file.
- gst-entrans requires gstreamer-plugins-entrans, so license is not required
(but you can keep it, with AUTHORS file, it's your choice)
Move
BuildRequires: gtk-doc
To gstreamer-plugins-entrans-docs sub-package
I think there is no legal issue, as no codec are provided.
Notice : for the /usr/share/gtk-doc/html directory ownership, guidelines allow
2 solutions.
- require an owner (gtk-doc)
- own the directory (to avoid to require more packages)
Both are ok. It's "your" choice (I think "gtk-doc" is required to
generate the
doc, not to read it...)
Everything else seems ok.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.