Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=887611
Alec Leamas <leamas.alec(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |leamas.alec(a)gmail.com
--- Comment #6 from Alec Leamas <leamas.alec(a)gmail.com> ---
Some other drive-by comments:
- As Mathias says, it's better to offer to trade reviews than to just ask for
one.
- Obviously you have updated the spec, but there are no notes in the changelog
[1]
- Are the %{optflags} in effect as required by[2]?
- The Buildroot: tag is not needed unless you are heading for EPEL5 [3]
- Use %global instead of %define [4]
- You should inform upstream about the bad FSF address in COPYING [5]
I'm particularly concerned about Mathias comment #2 about the lib/platform
files. What happened to those?
[1]
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
[2]
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
[3]
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
[4]
https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_o...
[5]
http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=whWkZmZHRb&a=cc_unsubscribe