https://bugzilla.redhat.com/show_bug.cgi?id=1889705
--- Comment #1 from Jitka Plesnikova <jplesnik(a)redhat.com> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires
FIX: Please add following build-requires:
perl-interpreter - perl-Test-Net-LDAP.spec:36
make - perl-Test-Net-LDAP.spec:37
coreutils - perl-Test-Net-LDAP.spec:45
If you don't want to add the package to EPEL 7, please consider fixing
these 'TODO' items:
TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL'
If you use option NO_PACKLIST=1, please add version constrain
to ExtUtils::MakeMaker >= 6.76
Remove "find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;".
TODO: Use %{make_install} instead of "make pure_install".
If you want to add it to EPEL 7, please do:
TODO: Replace PERL_INSTALL_ROOT with more common DESTDIR.
FIX: Add a build-require 'findutils' used in spec file.
$ rpm -qp --requires perl-Test-Net-LDAP-0.07-1.fc34.noarch.rpm | sort | uniq -c
| grep -v rpmlib
1 perl(base)
1 perl(Exporter)
1 perl(IO::Socket)
1 perl(:MODULE_COMPAT_5.32.0)
1 perl(Net::LDAP)
1 perl(Net::LDAP::Constant)
1 perl(Net::LDAP::Entry)
1 perl(Net::LDAP::Filter)
1 perl(Net::LDAP::FilterMatch)
1 perl(Net::LDAP::Util)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(Test::Builder)
1 perl(Test::Net::LDAP)
1 perl(Test::Net::LDAP::Mixin)
1 perl(Test::Net::LDAP::Util)
1 perl(:VERSION) >= 5.6.0
1 perl(warnings)
FIX: Add following run-requires:
perl(Net::LDAP::Bind) - lib/Test/Net/LDAP/Mock/Data.pm:181
perl(Net::LDAP::RootDSE) - lib/Test/Net/LDAP/Mock/Data.pm:92
perl(Net::LDAP::Search) - lib/Test/Net/LDAP/Mock/Data.pm:257
$ rpm -qp --provides perl-Test-Net-LDAP-0.07-1.fc34.noarch.rpm | sort | uniq -c
1 perl(Test::Net::LDAP) = 0.07
1 perl-Test-Net-LDAP = 0.07-1.fc34
1 perl(Test::Net::LDAP::Mixin)
1 perl(Test::Net::LDAP::Mock)
1 perl(Test::Net::LDAP::Mock::Data)
1 perl(Test::Net::LDAP::Mock::Node)
1 perl(Test::Net::LDAP::Util)
Binary provides are Ok.
$ rpmlint ./perl-Test-Net-LDAP*
perl-Test-Net-LDAP.noarch: W: spelling-error %description -l en_US ok -> OK,
och, pk
perl-Test-Net-LDAP.src: W: spelling-error %description -l en_US ok -> OK, och,
pk
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok
TODO: Remove "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null
\;".
It's not needed.
Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a
new
spec file.
Resolution:
NOT approved
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component