Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=665005
Iain Arnell <iarnell(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |iarnell(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |iarnell(a)gmail.com
Flag| |fedora-review?
--- Comment #2 from Iain Arnell <iarnell(a)gmail.com> 2011-01-19 23:31:29 EST ---
+ source files match upstream.
f3a89be749127dcf5b46b97befbfc916 Server-Starter-0.09.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
GPL+ or Artistic
+ license is open source-compatible.
+ license text not included upstream.
- latest version is being packaged.
0.11 is available now
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
http://koji.fedoraproject.org/koji/taskinfo?taskID=2732539
+ package installs properly.
- rpmlint has no complaints:
perl-Server-Starter.noarch: W: spelling-error Summary(en_US) Superdaemon ->
Super daemon, Super-daemon, Superdominant
perl-Server-Starter.noarch: W: spelling-error %description -l en_US
superdaemon -> super daemon, super-daemon, superdominant
perl-Server-Starter.noarch: W: spelling-error %description -l en_US
commenctions -> commendations, commensuration, commendation
perl-Server-Starter.noarch: W: spurious-executable-perm
/usr/share/doc/perl-Server-Starter-0.09/start_server
perl-Server-Starter.noarch: W: doc-file-dependency
/usr/share/doc/perl-Server-Starter-0.09/start_server perl(Getopt::Long)
perl-Server-Starter.noarch: W: doc-file-dependency
/usr/share/doc/perl-Server-Starter-0.09/start_server /usr/bin/perl
perl-Server-Starter.noarch: W: doc-file-dependency
/usr/share/doc/perl-Server-Starter-0.09/start_server perl(Pod::Usage)
perl-Server-Starter.src: W: spelling-error Summary(en_US) Superdaemon ->
Super daemon, Super-daemon, Superdominant
perl-Server-Starter.src: W: spelling-error %description -l en_US
superdaemon -> super daemon, super-daemon, superdominant
perl-Server-Starter.src: W: spelling-error %description -l en_US
commenctions -> commendations, commensuration, commendation
perl-Server-Starter.src:67: E: files-attr-not-set
perl-Server-Starter.src:68: E: files-attr-not-set
perl-Server-Starter-start_server.noarch: W: summary-not-capitalized C
perl-Server-Starter start_server script
- final provides and requires are sane:
$ rpm -qp --provides perl-Server-Starter-0.09-2.fc15.noarch.rpm
perl(Server::Starter) = 0.09
perl-Server-Starter = 0.09-2.fc15
$ rpm -qp --provides
perl-Server-Starter-start_server-0.09-2.fc15.noarch.rpm
perl-Server-Starter-start_server = 0.09-2.fc15
=
$ rpm -qp --requires perl-Server-Starter-0.09-2.fc15.noarch.rpm
/usr/bin/perl
perl >= 0:5.008
perl(:MODULE_COMPAT_5.12.2)
perl(Carp)
perl(Exporter)
perl(Fcntl)
perl(Getopt::Long)
perl(IO::Handle)
perl(IO::Socket::INET)
perl(List::MoreUtils)
perl(POSIX)
perl(Pod::Usage)
perl(Proc::Wait3)
perl(Scope::Guard)
perl(Server::Starter)
perl(strict)
perl(warnings)
$ rpm -qp --requires
./perl-Server-Starter-start_server-0.09-2.fc15.noarch.rpm |sort
perl(Getopt::Long)
perl(Pod::Usage)
perl(Server::Starter)
perl(strict)
perl(warnings)
+ %check is present and all tests pass.
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e"
"test_harness(0, 'inc', 'blib/lib', 'blib/arch')"
t/00-base.t t/01-starter.t
t/02-startfail.t
t/00-base.t ....... ok
start_server (pid:24883) starting now...
starting new worker 24886
received HUP, spawning a new worker
starting new worker 25823
new worker is now running, sending TERM to old workers:24886
old worker 24886 died, status:0
received TERM, sending TERM to all workers:25823
worker 25823 died, status:0
exitting
start_server (pid:30769) starting now...
starting new worker 30770
received HUP, spawning a new worker
starting new worker 32375
new worker is now running, sending USR1 to old workers:30770
old worker 30770 died, status:0
received TERM, sending TERM to all workers:32375
worker 32375 died, status:0
exitting
t/01-starter.t .... ok
start_server (pid:5389) starting now...
starting new worker 5390
new worker 5390 seems to have failed to start, exit status:256
starting new worker 5690
received HUP, spawning a new worker
starting new worker 6885
new worker 6885 seems to have failed to start, exit status:256
starting new worker 6886
new worker 6886 seems to have failed to start, exit status:256
starting new worker 7656
new worker is now running, sending TERM to old workers:5690
old worker 5690 died, status:0
received TERM, sending TERM to all workers:7656
worker 7656 died, status:0
exitting
t/02-startfail.t .. ok
All tests successful.
Files=3, Tests=38, 28 wallclock secs ( 0.02 usr 0.01 sys + 0.59 cusr
0.15 csys = 0.77 CPU)
Result: PASS
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
There's a few minor problems:
- newer version 0.11 is available
- start_server script shouldn't be in main package's %doc
- %files start_server section needs to set %defattr(-,root,root,-)
- spelling in description needs fixing (commenctions -> connections;
superdaemon is okay for me)
And I'm not entirely convinced that start_server needs its own sub-package, why
not just include it in the main package?
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.