https://bugzilla.redhat.com/show_bug.cgi?id=2253356
--- Comment #3 from Jerry James <loganjerry(a)gmail.com> ---
Thank you for the review, Benson.
(In reply to Benson Muite from comment #2)
a) Can the file src/lusol.txt be added to the documentation?
%doc src/lusol.txt
Sure. Wow, that's some ancient history in that file. :-)
b) Should the mod files lusol.mod and lusol_precision.mod be
packaged?
These are development files typically placed in %{_fmoddir} and devel package
must then have
Requires: gcc-gfortran%{_isa}
see
https://docs.fedoraproject.org/en-US/packaging-guidelines/Fortran/
Well, we could. I personally am interested in this package only for purposes
of unbundling it from papilo. For that, I only need the C interface. We could
provide the Fortran interface too, but I'm not sure I want to encourage anyone
to use this package. It seems unmaintained. As you probably noticed, I've got
2 pull requests from January and a bug report from August that have had no
activity at all. There have been no commits for over a year (and that commit
was just adding one line to .gitignore). I'm thinking of suggesting to the
papilo maintainers that they find a more maintained LU solver.
Anyway, I personally have no motivation to package the Fortran interface. What
do you think? Is it okay to just package the C interface, and add the Fortran
interface if somebody shows up who needs it? (I think that is highly unlikely,
by the way.)
c) Maybe also send a pull request to add soname upstream?
Upstream supports OS X builds as well as Linux builds. Do you know how sonames
are added for OS X? An upstream patch would have to handle both.
d) patch lusol-uninit.patch seems logical, but the code has no tests,
can
check
this, but would need a few days.
Yes, I need to pull my linear algebra textbook off the shelf and figure out if
that patch is correct.
Ah, it's a mistake in the makefile. Line 146:
# extra fortran dependencies
lusol.o : lusol_precision.mod
But both objects are actually in the src directory, so it's a race to see if
lusol_precision.mod is built in time. I sent a patch upstream:
https://github.com/nwh/lusol/pull/14
So I added src/lusol.txt to %doc and added a patch for the makefile race. The
URLs are the same as above.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2253356
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...