https://bugzilla.redhat.com/show_bug.cgi?id=1239273
--- Comment #11 from Jan Chaloupka <jchaloup(a)redhat.com> ---
%{gopath} macro is provided since golang-1.2.1-3 so BuildRequires must have:
BuildRequires: golang >= 1.2.1-3
for both main package and devel subpackage.
Are tests in tests directory used by toml-test binary only? If so, there is no
need for devel subpackage as json.go, main.go and results.go can not be
imported and there are no other source codes written in go. In that case these
lines:
%install
install -D -p -m 0755 bin/%{repo} %{buildroot}%{_bindir}/%{repo}
mkdir -p %{buildroot}%{_datadir}/%{repo}/
%if 0%{?with_devel}
# install devel source codes
install -d -p %{buildroot}/%{gopath}/src/%{import_path}/
cp -a tests %{buildroot}%{_datadir}/%{repo}/
# copy directories
cp -rpa tests %{buildroot}%{gopath}/src/%{import_path}/
%endif
can be changed to:
%install
install -D -p -m 0755 bin/%{repo} %{buildroot}%{_bindir}/%{repo}
mkdir -p %{buildroot}%{_datadir}/%{repo}/
cp -a tests %{buildroot}%{_datadir}/%{repo}/
%if 0%{?with_devel}
# install devel source codes
install -d -p %{buildroot}/%{gopath}/src/%{import_path}/
# copy directories
%endif
At the same time %{with_devel} can be set to 0 as there are no devel
files/directories at the moment.
Otherwise the spec LGTM.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component