Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=684006
--- Comment #3 from Paul Howarth <paul(a)city-fan.org> 2012-02-16 04:17:00 EST ---
Hi Bill,
I'd like to get this moving again; a couple of days ago I used this module in
anger and I think it's great! I'd forgotten all about this review request so I
cobbled together a package myself.
Anyway, a few more comments:
* I'd suggest using a patch to add perl shellbangs to the dtd2XMLRules.pl and
xml2XMLRules.pl scripts in %prep and then just ship them in %{_bindir} as
upstream intended.
* Consider packaging XML::DTDParser, which is needed by inferRulesFromDTD; if
you do so, add it as an explicit dependency of this package.
* You can drop the redundant buildreq perl(version).
* Consider dropping the explicit versioned Requires: for perl(XML::Parser) and
perl(XML::Parser::Expat); even RHEL-3 had sufficiently recent versions of
these.
* Consider adding BuildRequires: for perl(Carp), perl(constant),
perl(Exporter)
and perl(Scalar::Util), all of which live on CPAN and might be dual-lived as
separate packages in Fedora.
Cheers, Paul.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.