https://bugzilla.redhat.com/show_bug.cgi?id=1551339
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #7 from Petr Pisar <ppisar(a)redhat.com> ---
Spec file changes:
--- shelldap.spec.old 2018-03-15 10:44:57.000000000 +0100
+++ shelldap.spec 2018-03-31 18:49:35.000000000 +0200
@@ -1,15 +1,13 @@
-%global debug_package %{nil}
-
Name: shelldap
Version: 1.4.0
Release: 1%{?dist}
Summary: A shell-like interface for browsing LDAP servers
License: BSD
-URL:
https://bitbucket.org/mahlon/shelldap
-Source0:
https://bitbucket.org/mahlon/%{name}/downloads/%{name}-%{version}.tar.gz
+URL:
https://bitbucket.org/mahlon/%{name}
+Source0: %{url}/downloads/%{name}-%{version}.tar.gz
-BuildArchitectures: noarch
+BuildArch: noarch
BuildRequires: perl-generators perl-interpreter perl(Config) perl-podlators
# perl-generators takes care of the 'Requires' tag.
Recommends: perl(IO::Socket::SSL) perl(Authen::SASL)
perl(Term::ReadLine::Gnu)
@@ -21,12 +19,11 @@
%prep
%setup -q
-shebang=$(perl -MConfig -e 'print qq{$Config{startperl}}')
-sed -i 's|#!/usr/bin/env perl|'"${shebang}"'|' %{name}
+perl -MConfig -i -pe 's{^#!/usr/bin/env perl}{$Config{startperl}}' %{name}
%build
pod2man shelldap > shelldap.1
-tail -n +4 shelldap | awk '/^[^#]/{exit};1' > LICENSE.txt
+perl -n -e 'if(m/^#/){print if($. > 4)}else{exit 0}' shelldap >
LICENSE.txt
%install
mkdir -p %{buildroot}/%{_bindir}
@@ -36,7 +33,7 @@
%files
%license LICENSE.txt
-%doc README.md CHANGELOG
+%doc README.md CHANGELOG CONTRIBUTORS
%{_bindir}/shelldap
%{_mandir}/man1/shelldap.1.*
$ rpmlint shelldap.spec ../SRPMS/shelldap-1.4.0-1.fc29.src.rpm
../RPMS/noarch/shelldap-1.4.0-1.fc29.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
The package is good.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component