https://bugzilla.redhat.com/show_bug.cgi?id=2035222
--- Comment #26 from dm4(a)secondstate.io ---
Appreciate your advice to help us improve our spec file.
> %global gittag 0.10.0
> %global srpm_version 0.10.0
What's the point of this? Why don't you just set `Version: 0.10.0` and use
`%{version}` instead of these redundant macros?
We use `gittag` and `srpm_version` variables because we'll try to build SPRM on
CI each commit. We'll generate version number like `0.10.0-61-gc82da352` each
commit using `git describe --match "[0-9].[0-9]*" --tag`. Because `-` is not a
valid character for version in spec file, we'll replace `-` with `~` in
`gittag` and set `srpm_version`. This is why we use `gittag` and `srpm_version`
variables.
> BuildRequires:
gcc-c++,cmake,ninja-build,boost-devel,spdlog-devel,llvm-devel,lld-devel,git
I would recommend splitting this into one `BuildRequires: PACKAGENAME` line
for each dependency, preferably alphabetized. This way, the specfile and its
git diffs are more readable.
Please use the %cmake macros. You can consult
https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ for how to
use them.
You should not use globs in %files for shared directories[1].
[1]:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists
Please take a look at
https://docs.fedoraproject.org/en-US/packaging-guidelines/
#_downstream_so_name_versioning. The way you've versioned the .so does not
look correct to me.
The devel subpackage should depend on the base package. Take a look at
https://docs.fedoraproject.org/en-US/packaging-guidelines/
#_requiring_base_package. Once you do this, you can remove the duplicated
`%license` and `%doc` lines from the devel subpackage.
> License: ASL 2.0 and CC0
You must include a licensing breakdown, as per
https://docs.fedoraproject.org/en-US/packaging-guidelines/
LicensingGuidelines/#_dual_licensing_scenarios.
Thanks for your advice! We'll update our spec file in the following PR:
https://github.com/WasmEdge/WasmEdge/pull/1578
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2035222