Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705585
Thomas Spura <tomspur(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Summary|Review Request: |Review Request:
|fflas-ffpack-devel - Finite |fflas-ffpack - Finite field
|field linear algebra |linear algebra subroutines
|subroutines |
Flag| |fedora-review?
--- Comment #3 from Thomas Spura <tomspur(a)fedoraproject.org> 2011-05-25 15:11:37 EDT
---
Review:
Good:
- %files ok
- %install ok
- parallel make used
- %build maybe ok (see below for givaro problem)
- %prep ok
- BR ok
- no libs installed no postun etc needed
- no static libs
- no *la
- hacks look needed/ok
- source match upstrem:
ff3755ba79b622e9c37cc14818213eb5 fflas-ffpack-1.4.1.tar.gz
- license wrong: /usr/bin/fflasffpack-config is CeCILL-B
-> LGPLv2+ and CeCILL-B with a comment, which file is under which license
TODO:
* Please add a %check section, e.g. with "make check"
* I'm seeing:
*******************************************************************************
WARNING: GIVARO not found!
GIVARO version 3.4.0 or greater (<3.5) is required for some tests in this
library.
Please make sure GIVARO is installed and specify its location with the
option --with-givaro=<prefix> when running configure.
*******************************************************************************
-> A givaro update would be needed for this to solve (don't know what exactly
is now broken in this package, maybe you?)
* a doc subpackage would be really nice:
$ du -sh /usr/share/doc/fflas-ffpack-devel-1.4.1/ /usr/include/fflas-ffpack/
3,7M /usr/share/doc/fflas-ffpack-devel-1.4.1/
596K /usr/include/fflas-ffpack/
* missing requires:
$ rpm -qa --requires fflas-ffpack-devel
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
And this file:
/usr/include/fflas-ffpack/utils/args-parser.h:#include
"linbox/util/commentator.h"
-> R on linbox-devel is missing
* There are other files with wrong FSF address, but I wouldn't fix this, just
reporting upstream...:
licensecheck -r /usr/include/fflas* | grep incorrect
/usr/include/fflas-ffpack/utils/Matio.h: LGPL (v2 or later) (with incorrect FSF
address)
/usr/include/fflas-ffpack/utils/debug.h: LGPL (v2 or later) (with incorrect FSF
address)
/usr/include/fflas-ffpack/fflas-ffpack.h: LGPL (v2 or later) (with incorrect
FSF address)
/usr/include/fflas-ffpack/field/modular-balanced-int32.h: LGPL (v2 or later)
(with incorrect FSF address)
/usr/include/fflas-ffpack/field/unparametric.h: LGPL (v2 or later) (with
incorrect FSF address)
/usr/include/fflas-ffpack/field/modular-int32.h: LGPL (v2 or later) (with
incorrect FSF address)
/usr/include/fflas-ffpack/field/modular-balanced-int64.h: LGPL (v2 or later)
(with incorrect FSF address)
/usr/include/fflas-ffpack/field/modular-int64.h: LGPL (v2 or later) (with
incorrect FSF address)
/usr/include/fflas-ffpack/config-blas.h: LGPL (v2 or later) (with incorrect FSF
address)
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.