https://bugzilla.redhat.com/show_bug.cgi?id=993324
Michael Schwendt <bugs.michael(a)gmx.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #785775| |review+
Flags| |
--- Comment #11 from Michael Schwendt <bugs.michael(a)gmx.net> ---
Created attachment 785775
-->
https://bugzilla.redhat.com/attachment.cgi?id=785775&action=edit
final spec file modifications
These are the last modifications I would suggest for the spec file:
* the noarch -devel package
* an empty %build section, albeit only to silence rpmlint
* the dist tag:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Using_the_.25.7...
* preserved time stamps for copied files:
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
* a trailing slash for the included directory tree in %files list (just for
increased readability - not mandatory - also see further below)
[...]
With regard to general packaging quality, it would also be an idea to be more
explicit about which files to include. For example,
%dir %{_includedir}/ell
%{_includedir}/ell/*.h
would make the build fail, if no header files are found, whereas with the
current spec,
%{_includedir}/ell/
even an empty directory would result in a successful build. Alternatively, one
can add safety/sanity checks to the %check section, too.
I just point this out, because it's a single line in the %install section that
copies the headers dir -> a single point of failure.
[...]
The remaining changes to the package may be applied in Fedora package git, so
no need to make available another revision here in the review ticket.
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=VnXZBksC6L&a=cc_unsubscribe