Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the
world!)
https://bugzilla.redhat.com/show_bug.cgi?id=253910
limb(a)jcomserv.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review?
------- Additional Comments From limb(a)jcomserv.net 2007-09-08 11:28 EST -------
rpmlint is clean on RPM, but on SRPM:
ksirk.src:35: E: hardcoded-library-path in %{_prefix}/lib/lib%{name}_*.la
A library path is hardcoded to one of the following paths: /lib,
/usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.
ksirk.src:39: E: hardcoded-library-path in %{_prefix}/lib/lib%{name}_*.so
A library path is hardcoded to one of the following paths: /lib,
/usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.
This should probably be patched, should it not?
Also, I see shared libs, but no ldconfig in post or postun.
Running a mock build to double-check BRs, but it otherwise looks great.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.