https://bugzilla.redhat.com/show_bug.cgi?id=2120129
--- Comment #4 from Alessandro Astone <ales.astone(a)gmail.com> ---
(In reply to Maíra Canal from comment #3)
Hi Alessandro,
Just a few nitpicks on your spec.
> %global pypi_name pyclip
Setting and using this macro makes the spec file harder to read. Using the
literal name makes it easier to read. Moreover, sometimes you don't even use
this macro and write "pyclip" literally, for example, on the URL.
I
don't know about that. I just followed what all other pypi specs do.
%{pypi_name} in github URL doesn't make sense.
> %package -n python%{python3_pkgversion}-%{pypi_name}
Instead of %{python3_pkgversion}, you can use simply 3.
I think
%{python3_pkgversion} here is correct
> BuildRequires: pyproject-rpm-macros
I believe this package is not needed for building.
Removed.
Moreover, pyclip contains tests that are not being called on the spec
file.
It would be nice to have the tests.
I suppose I could try adding the tests. However they require an X server
running for testing the X clipboard, and a Wayland server for testing the
wayland clipboard.
There already are bash snippets to do this in github CI
(.github/workflows/unittests.yml) that i could replicate, but i'm not sure if
we want to do that
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2120129